quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #171: QUICKSTEP-68 Reorder intermediate rel...
Date Mon, 30 Jan 2017 06:54:54 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/171#discussion_r98383388
  
    --- Diff: query_optimizer/PhysicalGenerator.cpp ---
    @@ -109,6 +114,13 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {
       } else {
         rules.emplace_back(new SwapProbeBuild());
       }
    +  if (FLAGS_reorder_columns) {
    +    // NOTE(jianqiao): This optimization relies on the fact that the intermediate
    +    // relations all have SPLIT_ROW_STORE layouts. If this fact gets changed, the
    +    // optimization algorithm may need to be updated and the performance impact
    +    // should be re-evaluated.
    --- End diff --
    
    I suggest to check this assumption in `ReorderColumns::IsTransformable`, so we could remove
this comment here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message