quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #166: Make the third party directory leaner
Date Wed, 25 Jan 2017 16:23:52 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/166#discussion_r97817049
  
    --- Diff: CMakeLists.txt ---
    @@ -694,8 +698,9 @@ else()
       include_directories(${CMAKE_CURRENT_BINARY_DIR}/third_party)
     endif()
     
    -add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2_cmake" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
    +#add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2_cmake" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
     include_directories("${THIRD_PARTY_SOURCE_DIR}/re2")
    +add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
    --- End diff --
    
    Removed the dead code. If I change the order of 702 and 703, it gives me following error,
and hence include first and add subdirectory later. 
    ```
    ...third_party/src/re2/re2/bitstate.cc:24:26: fatal error: util/logging.h: No such file
or directory
     #include "util/logging.h"
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message