quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #162: Added partition_id in RelationalOpera...
Date Wed, 18 Jan 2017 21:16:13 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/162#discussion_r96735370
  
    --- Diff: query_execution/tests/QueryManagerSingleNode_unittest.cpp ---
    @@ -177,8 +177,8 @@ class MockOperator: public RelationalOperator {
         return true;
       }
     
    -  void feedInputBlock(const block_id input_block_id,
    -                      const relation_id input_relation_id) override {
    +  void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id,
    +                      const partition_id part_id) override {
    --- End diff --
    
    Actually, I used the second example in [Function Declarations and Definitions](https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions).
    
    ```
    ReturnType ClassName::ReallyLongFunctionName(Type par_name1, Type par_name2,
                                                 Type par_name3) {
      DoSomething();
      ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message