quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #160: Added optimizer support regarding has...
Date Tue, 17 Jan 2017 16:26:04 GMT
Github user jianqiao commented on a diff in the pull request:

    --- Diff: query_optimizer/logical/CreateTable.hpp ---
    @@ -100,8 +108,9 @@ class CreateTable : public Logical {
       static CreateTablePtr Create(
           const std::string &relation_name,
           const std::vector<expressions::AttributeReferencePtr> &attributes,
    -      const std::shared_ptr<const StorageBlockLayoutDescription> &block_properties)
    -    return CreateTablePtr(new CreateTable(relation_name, attributes, block_properties));
    +      const std::shared_ptr<const StorageBlockLayoutDescription> &block_properties,
    +      const std::shared_ptr<const serialization::PartitionSchemeHeader> &partition_scheme_header_proto)
    --- End diff --
    Add a comment for `partition_scheme_header_proto` in method header (and mention that `partition_scheme_header_proto`
can be `nullptr` if not specified).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message