quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #161: Removed the unused feedInputBlocks.
Date Mon, 16 Jan 2017 17:22:18 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/161#discussion_r96274584
  
    --- Diff: relational_operators/NestedLoopsJoinOperator.hpp ---
    @@ -141,9 +141,16 @@ class NestedLoopsJoinOperator : public RelationalOperator {
         }
       }
     
    -  void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id)
override;
    -
    -  void feedInputBlocks(const relation_id rel_id, std::vector<block_id> *partially_filled_blocks)
override;
    +  void feedInputBlock(const block_id input_block_id, const relation_id input_relation_id)
override {
    +    if (input_relation_id == left_input_relation_.getID()) {
    +      left_relation_block_ids_.push_back(input_block_id);
    +    } else if (input_relation_id == right_input_relation_.getID()) {
    +      right_relation_block_ids_.push_back(input_block_id);
    +    } else {
    +      FATAL_ERROR("The input block sent to the NestedLoopsJoinOperator belongs "
    --- End diff --
    
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message