quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #154: Quickstep-63 Fix PlanVisualizer's cra...
Date Thu, 15 Dec 2016 00:57:57 GMT
GitHub user jianqiao opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/154

    Quickstep-63 Fix PlanVisualizer's crashes on physical plans unsupported by StarSchemaSimpleCostModel.

    `PlanVisualizer` would result in crashes on some queries (i.e., `CreateTable`) which do
not have corresponding physical plan support in `StarSchemaSimpleCostModel::estimateCardinality`.
    
    This PR fixes this problem by:
    (1) Let the cost models throw `UnsupportedPhysicalPlan` exception for unsupported plans.
    (2) `PlanVisualizer` simply catches the exceptions and omits the cardinality info for
unsupported physical nodes.
    
    Assigned to @zuyu 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep fix-plan-visualizer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 519483877eb1d392b038544c3df40537f42f0d9d
Author: Jianqiao Zhu <jianqiao@cs.wisc.edu>
Date:   2016-12-15T00:41:38Z

    Fixed PlanVisualizer crashes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message