quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From saketj <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #153: QUICKSTEP-65 Fix Quickstep build fail...
Date Tue, 06 Dec 2016 16:08:39 GMT
GitHub user saketj opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/153

    QUICKSTEP-65 Fix Quickstep build failure on Mac OSX 10.12

    Quickstep build on Mac OSX 10.12 fails due to deprecation of certain system APIs in the
new OSX version. The Quickstep code does not rely on these deprecated APIs, but it is the
protobuf library which uses these deprecated APIs. [See: https://github.com/google/protobuf/issues/2182]
    Although, this has been resolved in the latest master of protobuf [See: https://github.com/google/protobuf/pull/2337],
Quickstep protobuf cmake integration file has to be updated resolve this.
    As this is turning out to be a blocker for the dev environment, this JIRA proposes a quick
short-term fix for this issue by specifically turning off deprecation errors on OSX 10.12
platform. The more stable long-term fix would be to port the protobuf_cmake to the newest
protobuf version. However, that requires some non-trivial effort and will be done through
a separate JIRA.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/saketj/incubator-quickstep fix-osx-build-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #153
    
----
commit 6ae0cdd3d5db40febc98be00ce94baeed31ba680
Author: Saket Saurabh <ssaurabh@cs.wisc.edu>
Date:   2016-12-06T15:53:57Z

    QUICKSTEP-65 Fix Quickstep build failure on Mac OSX 10.12 by turning off deprecation errors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message