Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: cramja <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-129-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-129-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #129: Partial inserts
Content-Type: text/plain
Message-Id: <20161117221631.D59BEE0C0A@git1-us-west.apache.org>
Date: Thu, 17 Nov 2016 22:16:31 +0000 (UTC)
archived-at: Thu, 17 Nov 2016 22:16:38 -0000

Github user cramja commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/129#discussion_r88559668
  
    --- Diff: storage/StorageBlockLayout.cpp ---
    @@ -154,11 +154,7 @@ StorageBlockLayout* StorageBlockLayout::GenerateDefaultLayout(const CatalogRelat
       description->set_num_slots(1);
     
       TupleStorageSubBlockDescription *tuple_store_description = description->mutable_tuple_store_description();
    -  if (relation_variable_length) {
    -    tuple_store_description->set_sub_block_type(TupleStorageSubBlockDescription::SPLIT_ROW_STORE);
    -  } else {
    -    tuple_store_description->set_sub_block_type(TupleStorageSubBlockDescription::PACKED_ROW_STORE);
    -  }
    +  tuple_store_description->set_sub_block_type(TupleStorageSubBlockDescription::SPLIT_ROW_STORE);
    --- End diff --
    
    Just kidding. We need the default block type to be `SPLIT` because, if it's not, then the now-required partial bulk insert method which has not been implemented in the packed row store will cause a crash during query execution..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---