quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #131: Unified WorkOrderCompletionMessage proto.
Date Fri, 18 Nov 2016 20:24:30 GMT
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/131
  
    Yes, and if there is a new field dedicated to one case, say `RebuildWorkOrder`, we would
create the new protobuf message extending `WorkOrderCompletionMessage` as following:
    
    ```
    message RebuildWorkOrderCompletionMessage {
      extends WorkOrderCompletionMessage {
        // Add the new field.
      }
    }
    ```
    
    As I said in the PR description, I need this way in the following PR #137 to refactor
[`PolicyEnforcerBase::decrementNumQueuedWorkOrders`](https://github.com/apache/incubator-quickstep/pull/137/files#diff-fa94240de06b90bf57c8b9fdc3403d71R93).
    
    And I welcome alternative ways to achieve the same goal as #137.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message