quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #131: Unified WorkOrderCompletionMessage proto.
Date Fri, 18 Nov 2016 20:16:14 GMT
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/131
  
    Hi Zuyu,
    
    We had a discussion about this design earlier and we came up to the conclusion that it
serves us better in the future to have different types for normal work order completion and
rebuild work order completion. In fact, I also documented the reasons for this bifurcation
in the source code. For convenience, I am describing that comment below: 
    
    ```
    Note: There are different types of completion messages for normal work orders  
    rebuild work orders. This can be potentially helpful when we want to collect   
    different statistics for executing different types of work orders.                
    e.g. In select normal work order completion message, we could be interested       
    in the selectivity of the block whose work order got execute. In rebuild work  
    order completion message, we may be interested in adding the compression          
    ratio or dictionary size of the rebuilt block.
    ```
    
    Given this, I am not sure if we still need to go back to the old way. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message