quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #122: Add backend support for LIPFilters.
Date Mon, 24 Oct 2016 21:37:04 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    --- Diff: storage/StorageBlock.cpp ---
    @@ -340,22 +340,16 @@ void StorageBlock::sample(const bool is_block_sample,
     void StorageBlock::select(const vector<unique_ptr<const Scalar>> &selection,
    -                          const Predicate *predicate,
    -                          InsertDestinationInterface *destination) const {
    +                          InsertDestinationInterface *destination,
    +                          const TupleIdSequence *filter) const {
    --- End diff --
    Can we move the ``filter`` argument before ``destination``, as per Google style guide?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message