quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion
Date Tue, 18 Oct 2016 21:48:47 GMT
Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/109
  
    @cramja In general looks good. I agree with Navneet that `setMemory()` does not look like
a safe public method (there are other `const` members in the `BitVector` class not addressed)
-- the method seems to be just applicable in very limited scenarios. Anyway let's merge this
PR first, and I can help revise `setMemory()` later when working on the reordering-output-attributes
stuff.
    
    Can you rebase the branch and commit it to `apache:splitrow_insert_refactor`? Seems that
I cannot access the `cramja:splitrow_insert_refactor` branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message