quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #111: Initiated query execution data struct...
Date Tue, 18 Oct 2016 15:14:33 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/111#discussion_r83672097
  
    --- Diff: query_execution/PolicyEnforcerBase.hpp ---
    @@ -163,6 +174,8 @@ class PolicyEnforcerBase {
       // Key = query ID, value = QueryManagerBase* for the key query.
       std::unordered_map<std::size_t, std::unique_ptr<QueryManagerBase>> admitted_queries_;
     
    +  std::unordered_set<std::size_t> removed_query_ids_;
    --- End diff --
    
    Does this set mean IDs for the queries which have finished their execution? If so, why
do we need this list? Isn't that increasing the overhead of metadata management? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message