quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #99: QUICKSTEP-36 Quickstep gives segmentat...
Date Wed, 14 Sep 2016 14:33:18 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/99#discussion_r78760515
  
    --- Diff: relational_operators/TextScanOperator.cpp ---
    @@ -19,6 +19,12 @@
     
     #include "relational_operators/TextScanOperator.hpp"
     
    +#include "relational_operators/RelationalOperatorsConfig.h"  // For QUICKSTEP_HAVE_UNISTD.
    --- End diff --
    
    @hbdeshmukh No, this line is ok, as the next line immediately uses `QUICKSTEP_HAVE_UNISTD`
defined in the header file.
    
    See https://github.com/apache/incubator-quickstep/blob/master/storage/StorageManager.cpp#L20
for more info and examples.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message