quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #99: QUICKSTEP-36 Quickstep gives segmentat...
Date Mon, 12 Sep 2016 14:28:17 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/99#discussion_r78382769
  
    --- Diff: relational_operators/TextScanOperator.cpp ---
    @@ -18,6 +18,11 @@
      **/
     
     #include "relational_operators/TextScanOperator.hpp"
    +#include "relational_operators/RelationalConfig.h"
    --- End diff --
    
    Can you sort the above two included files alphabetically? We follow a convention that
lists of included files are sorted. If you are dealing with a large list of included files,
you may use your IDE's sorting feature, instead of manual effort. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message