quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #96: QUICKSTEP-43 Introduced DestroyAggregationSta...
Date Mon, 05 Sep 2016 21:51:48 GMT
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/96
  
    Hi @zuyu 
    
    Applied your suggestions. Thanks.
    
    > As a side node for the new DestroyAggregationStateWorkOrder, we don't need this new
method. Instead, using releaseAggregationState and the unique_ptr in the WorkOrder automatically
destroys the content.
    
    This change caused some of the tests (Aggregation operator unit test and execution generator
- select, distinct and join) to fail. I didn't follow up on why they were failing and stuck
to using ``destroyAggregationState`` instead. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message