quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #96: QUICKSTEP-43 Introduced DestroyAggrega...
Date Mon, 05 Sep 2016 20:04:58 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/96#discussion_r77553580
  
    --- Diff: query_execution/QueryContext.hpp ---
    @@ -195,6 +195,17 @@ class QueryContext {
       }
     
       /**
    +   * @brief Destroy the given aggregation state.
    +   *
    +   * @param id The ID of the AggregationOperationState to destroy.
    +   **/
    +  inline void destroyAggregationState(const aggregation_state_id id) {
    --- End diff --
    
    As a side node for the new `DestroyAggregationStateWorkOrder`, we don't need this new
method. Instead, using `releaseAggregationState` and the `unique_ptr` in the `WorkOrder` automatically
destroys the content.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message