quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #96: QUICKSTEP-43 Introduced DestroyAggrega...
Date Mon, 05 Sep 2016 20:00:45 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/96#discussion_r77553384
  
    --- Diff: query_execution/QueryContext.hpp ---
    @@ -184,7 +184,7 @@ class QueryContext {
       /**
        * @brief Release the given AggregationOperationState.
        *
    -   * @param id The id of the AggregationOperationState to destroy.
    +   * @param id The id of the AggregationOperationState to release.
    --- End diff --
    
    @hbdeshmukh Since we changed the semantics of `FinalizeAggregationOperator`, when constructing
`FinalizeAggregationWorkOrder`, [`WorkOrderFactory`](https://github.com/apache/incubator-quickstep/pull/96/files#diff-2c12385b34f03b5eb61a3f5df00505eeR157)
should also use the get version instead. And it fixes the distributed unit tests. Otherwise,
it would also cause memory leaks for the distributed version.
    
    @pateljm The test failures are related to the missed changes in new feature for the distributed
version, not my existing code. The main components in the distributed query execution engine
was code reviewed, although not the test drivers (but the most driver code is forked from
the existing codebase).
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message