quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #96: QUICKSTEP-43 Introduced DestroyAggregationSta...
Date Fri, 02 Sep 2016 03:02:07 GMT
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/96
  
    Hi @zuyu 
    
    I am not sure what's causing the failures. The check is similar to other methods related
to aggregation state. I am not quite familiar with the distributed version tests, so if you
can let me know why this check is not appropriate, that could be helpful. 
    
    On a side note, the QueryContext class lacks thread safety right now. For bigger query
plans when several operators are under execution, there could be data races which can corrupt
the class members. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message