Return-Path: <dev-return-1044-archive-asf-public=cust-asf.ponee.io@quickstep.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 758E7200B63
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 15 Aug 2016 19:13:48 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 74295160AA7; Mon, 15 Aug 2016 17:13:48 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BB6F4160A8A
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 15 Aug 2016 19:13:47 +0200 (CEST)
Received: (qmail 48090 invoked by uid 500); 15 Aug 2016 17:13:47 -0000
Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@quickstep.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@quickstep.incubator.apache.org>
List-Post: <mailto:dev@quickstep.incubator.apache.org>
List-Id: <dev.quickstep.incubator.apache.org>
Reply-To: dev@quickstep.incubator.apache.org
Delivered-To: mailing list dev@quickstep.incubator.apache.org
Received: (qmail 48075 invoked by uid 99); 15 Aug 2016 17:13:46 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 17:13:46 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5CE621A0483
	for <dev@quickstep.apache.org>; Mon, 15 Aug 2016 17:13:46 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx2-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id 99mSk9EJDc86 for <dev@quickstep.apache.org>;
	Mon, 15 Aug 2016 17:13:44 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id F11FA5FC06
	for <dev@quickstep.incubator.apache.org>; Mon, 15 Aug 2016 17:13:43 +0000 (UTC)
Received: (qmail 48056 invoked by uid 99); 15 Aug 2016 17:13:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 17:13:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 3EEA7DFFC0; Mon, 15 Aug 2016 17:13:43 +0000 (UTC)
From: hbdeshmukh <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-90-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-90-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #90: Quickstep 28 29
Content-Type: text/plain
Message-Id: <20160815171343.3EEA7DFFC0@git1-us-west.apache.org>
Date: Mon, 15 Aug 2016 17:13:43 +0000 (UTC)
archived-at: Mon, 15 Aug 2016 17:13:48 -0000

Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/90#discussion_r74796117
  
    --- Diff: storage/StorageBlock.hpp ---
    @@ -466,6 +466,14 @@ class StorageBlock : public StorageBlockBase {
                             std::vector<std::unique_ptr<ColumnVector>>
                                 *reuse_group_by_vectors) const;
     
    +
    +  void aggregateGroupByFast(const std::vector<std::vector<std::unique_ptr<const Scalar>>> &arguments,
    +                        const std::vector<std::unique_ptr<const Scalar>> &group_by,
    +                        const Predicate *predicate,
    +                        AggregationStateHashTableBase *hash_table,
    +                        std::unique_ptr<TupleIdSequence> *reuse_matches,
    +                        std::vector<std::unique_ptr<ColumnVector>>
    +                            *reuse_group_by_vectors) const;
    --- End diff --
    
    Can you please align the parameters and add doxygen comments? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---