Return-Path: <dev-return-922-archive-asf-public=cust-asf.ponee.io@quickstep.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3D02E200B7E
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  2 Aug 2016 03:08:34 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 3BB63160A6C; Tue,  2 Aug 2016 01:08:34 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 8489B160AA7
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  2 Aug 2016 03:08:33 +0200 (CEST)
Received: (qmail 90910 invoked by uid 500); 2 Aug 2016 01:08:32 -0000
Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@quickstep.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@quickstep.incubator.apache.org>
List-Post: <mailto:dev@quickstep.incubator.apache.org>
List-Id: <dev.quickstep.incubator.apache.org>
Reply-To: dev@quickstep.incubator.apache.org
Delivered-To: mailing list dev@quickstep.incubator.apache.org
Received: (qmail 90858 invoked by uid 99); 2 Aug 2016 01:08:32 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 01:08:32 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 23F35C14D4
	for <dev@quickstep.apache.org>; Tue,  2 Aug 2016 01:08:32 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx2-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id kmReRqU9rqUo for <dev@quickstep.apache.org>;
	Tue,  2 Aug 2016 01:08:31 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 13C6A60E25
	for <dev@quickstep.incubator.apache.org>; Tue,  2 Aug 2016 01:08:30 +0000 (UTC)
Received: (qmail 84169 invoked by uid 99); 2 Aug 2016 01:08:25 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2016 01:08:25 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B8A09E058E; Tue,  2 Aug 2016 01:08:25 +0000 (UTC)
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-73-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-73-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...
Content-Type: text/plain
Message-Id: <20160802010825.B8A09E058E@git1-us-west.apache.org>
Date: Tue,  2 Aug 2016 01:08:25 +0000 (UTC)
archived-at: Tue, 02 Aug 2016 01:08:34 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/73#discussion_r73080240
  
    --- Diff: query_optimizer/rules/SwapProbeBuild.hpp ---
    @@ -0,0 +1,46 @@
    +#ifndef QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_
    +#define QUICKSTEP_QUERY_OPTIMIZER_RULES_SWAP_PROBE_BUILD_HPP_
    +
    +#include <string>
    +
    +#include "query_optimizer/physical/Physical.hpp"
    +#include "query_optimizer/rules/Rule.hpp"
    +#include "query_optimizer/rules/BottomUpRule.hpp"
    +#include "query_optimizer/cost_model/StarSchemaSimpleCostModel.hpp"
    +#include "utility/Macros.hpp"
    +
    +namespace quickstep {
    +namespace optimizer {
    +
    +/** \addtogroup OptimizerRules
    + *  @{
    + */
    +
    +namespace P = ::quickstep::optimizer::physical;
    +namespace E = ::quickstep::optimizer::expressions;
    +namespace C = ::quickstep::optimizer::cost;
    +
    +/**
    + * @brief Rule that applies to a physical plan to arrange probe and
    + *        build side based on the cardinalities.
    + */
    +class SwapProbeBuild : public BottomUpRule<P::Physical> {
    + public:
    +  SwapProbeBuild() {
    +  }
    +
    +  std::string getName() const override { return "SwapProbeBuild"; }
    +
    + protected:
    +  P::PhysicalPtr applyToNode(const P::PhysicalPtr &input) override;
    +
    + private:
    +  DISALLOW_COPY_AND_ASSIGN(SwapProbeBuild);
    +
    +  std::unique_ptr<C::StarSchemaSimpleCostModel> cost_model_;
    --- End diff --
    
    Actually, we should use the base class of the cost model, and initiate some implementation as @jianqiao suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---