quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #96: QUICKSTEP-43 Introduced DestroyAggrega...
Date Tue, 23 Aug 2016 21:32:48 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/96#discussion_r75955440
  
    --- Diff: relational_operators/DestroyAggregationStateOperator.hpp ---
    @@ -0,0 +1,118 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + **/
    +
    +#ifndef QUICKSTEP_RELATIONAL_OPERATORS_DESTROY_AGGREGATION_STATE_OPERATOR_HPP_
    +#define QUICKSTEP_RELATIONAL_OPERATORS_DESTROY_AGGREGATION_STATE_OPERATOR_HPP_
    +
    +#include <string>
    +
    +#include "query_execution/QueryContext.hpp"
    +#include "relational_operators/RelationalOperator.hpp"
    +#include "relational_operators/WorkOrder.hpp"
    +#include "utility/Macros.hpp"
    +
    +#include "glog/logging.h"
    +
    +#include "tmb/id_typedefs.h"
    +
    +namespace tmb { class MessageBus; }
    +
    +namespace quickstep {
    +
    +class StorageManager;
    +class WorkOrderProtosContainer;
    +class WorkOrdersContainer;
    +
    +/** \addtogroup RelationalOperators
    + *  @{
    + */
    +
    +/**
    + * @brief An operator which destroys a shared aggregation state.
    + **/
    +class DestroyAggregationStateOperator : public RelationalOperator {
    + public:
    +  /**
    +   * @brief Constructor.
    +   *
    +   * @param query_id The ID of the query to which this operator belongs.
    +   * @param aggr_state_index The index of the AggregationState in QueryContext.
    +   **/
    +  DestroyAggregationStateOperator(const std::size_t query_id,
    +                      const QueryContext::aggregation_state_id aggr_state_index)
    +      : RelationalOperator(query_id),
    +        aggr_state_index_(aggr_state_index),
    +        work_generated_(false) {}
    +
    +  ~DestroyAggregationStateOperator() override {}
    +
    +  std::string getName() const override {
    +    return "DestroyAggregationStateOperator";
    +  }
    +
    +  bool getAllWorkOrders(WorkOrdersContainer *container,
    +                        QueryContext *query_context,
    +                        StorageManager *storage_manager,
    +                        const tmb::client_id scheduler_client_id,
    +                        tmb::MessageBus *bus) override;
    +
    +  bool getAllWorkOrderProtos(WorkOrderProtosContainer *container) override;
    +
    + private:
    +  const QueryContext::aggregation_state_id aggr_state_index_;
    +  bool work_generated_;
    +
    +  DISALLOW_COPY_AND_ASSIGN(DestroyAggregationStateOperator);
    +};
    +
    +/**
    + * @brief A WorkOrder produced by DestroyAggregationStateOperator.
    + **/
    +class DestroyAggregationStateWorkOrder : public WorkOrder {
    + public:
    +  /**
    +   * @brief Constructor.
    +   *
    +   * @param query_id The ID of the query to which this WorkOrder belongs.
    +   * @param aggr_state_index The index of the AggregationState in QueryContext.
    +   * @param query_context The QueryContext to use.
    +   **/
    +  DestroyAggregationStateWorkOrder(const std::size_t query_id,
    +                       const QueryContext::aggregation_state_id aggr_state_index,
    +                       QueryContext *query_context)
    --- End diff --
    
    Code style: Please align w/ `Line 96`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message