quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #96: QUICKSTEP-43 Introduced DestroyAggrega...
Date Tue, 23 Aug 2016 21:25:30 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/96#discussion_r75954125
  
    --- Diff: query_execution/QueryContext.hpp ---
    @@ -184,7 +184,7 @@ class QueryContext {
       /**
        * @brief Release the given AggregationOperationState.
        *
    -   * @param id The id of the AggregationOperationState to destroy.
    +   * @param id The id of the AggregationOperationState to release.
    --- End diff --
    
    I think we could remove this method, as it will not be used any more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message