quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #90: Quickstep 28 29
Date Mon, 15 Aug 2016 16:19:58 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/90#discussion_r74787900
  
    --- Diff: expressions/aggregation/AggregationConcreteHandle.hpp ---
    @@ -302,6 +191,12 @@ class HashTableAggregateFinalizer {
         output_column_vector_->appendTypedValue(handle_.finalizeHashTableEntry(group_state));
       }
     
    +  inline void operator()(const std::vector<TypedValue> &group_by_key,
    --- End diff --
    
    Can you please add doxygen for this functor? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message