quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #90: Quickstep 28 29
Date Mon, 15 Aug 2016 16:18:43 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/90#discussion_r74787702
  
    --- Diff: expressions/aggregation/AggregationConcreteHandle.hpp ---
    @@ -27,10 +27,12 @@
     #include "catalog/CatalogTypedefs.hpp"
     #include "expressions/aggregation/AggregationHandle.hpp"
     #include "storage/HashTable.hpp"
    +#include "storage/FastHashTable.hpp"
    --- End diff --
    
    A minor clarification, all the #include statements in the current block. You can leave
out the #include glog block below as is. The #include block below is for third party includes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message