quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #90: Quickstep 28 29
Date Mon, 15 Aug 2016 16:11:45 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/90#discussion_r74786607
  
    --- Diff: expressions/aggregation/AggregationHandle.hpp ---
    @@ -347,20 +348,15 @@ class AggregationHandle {
        */
       virtual void aggregateOnDistinctifyHashTableForGroupBy(
           const AggregationStateHashTableBase &distinctify_hash_table,
    -      AggregationStateHashTableBase *aggregation_hash_table) const = 0;
    +      AggregationStateHashTableBase *aggregation_hash_table,
    +      int index) const = 0;
     
    -  /**
    -   * @brief Merge two GROUP BY hash tables in one.
    -   *
    -   * @note Both the hash tables should have the same structure.
    -   *
    -   * @param source_hash_table The hash table which will get merged.
    -   * @param destination_hash_table The hash table to which we will merge the
    -   *        other hash table.
    -   **/
    -  virtual void mergeGroupByHashTables(
    -      const AggregationStateHashTableBase &source_hash_table,
    -      AggregationStateHashTableBase *destination_hash_table) const = 0;
    +  virtual size_t getPayloadSize() const {return 1;}
    +  virtual void iterateInlFast(const std::vector<TypedValue> &arguments, uint8_t
*byte_ptr) const {}
    +  virtual void mergeStatesFast(const uint8_t *src, uint8_t *dst) const {}
    +  virtual void initPayload(uint8_t *byte_ptr) const {}
    +  virtual void BlockUpdate() {}
    +  virtual void AllowUpdate() {}
    --- End diff --
    
    Can you please add doxygen for these methods? Also, as a convention, non-static method
names start with a lowercase letter - so can you please rename the methods to ``blockUpdate``
and ``allowUpdate``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message