quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #90: Quickstep 28 29
Date Mon, 15 Aug 2016 16:10:09 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/90#discussion_r74786349
  
    --- Diff: expressions/aggregation/AggregationHandle.hpp ---
    @@ -347,20 +348,15 @@ class AggregationHandle {
        */
       virtual void aggregateOnDistinctifyHashTableForGroupBy(
           const AggregationStateHashTableBase &distinctify_hash_table,
    -      AggregationStateHashTableBase *aggregation_hash_table) const = 0;
    +      AggregationStateHashTableBase *aggregation_hash_table,
    +      int index) const = 0;
    --- End diff --
    
    Can you please update the doxygen for the ``index`` parameter? Also, if the index is always
positive, can you change its type from int to std::size_t?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message