quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #76: Visualize execution plan DAGs annotate...
Date Wed, 03 Aug 2016 17:52:40 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/76#discussion_r73384721
  
    --- Diff: query_execution/QueryExecutionTypedefs.hpp ---
    @@ -98,6 +98,12 @@ enum QueryExecutionMessageType : message_type_id {
     #endif
     };
     
    +// WorkOrder profiling data structures.
    +// A tuple of <Worker ID, Operator ID, Start Time, End Time>
    +typedef std::tuple<std::size_t, std::size_t, std::size_t, std::size_t> WorkOrderTimeEntry;
    --- End diff --
    
    It may be helpful to make WorkOrderTimeEntry as a struct with the parameters as public
variables. That way we will be less concerned about the ordering of the parameters and any
potential bugs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message