quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...
Date Wed, 03 Aug 2016 07:11:42 GMT
Github user jianqiao commented on a diff in the pull request:

    --- Diff: query_optimizer/rules/BottomUpRule.hpp ---
    @@ -80,6 +81,14 @@ class BottomUpRule : public Rule<TreeType> {
       virtual TreeNodePtr applyToNode(const TreeNodePtr &node) = 0;
    +  /**
    +   * @brief Initialization code to be used for each node.
    --- End diff --
    The initialization is only applied with the tree's root node but not "each node".
    Other places look good. I'll do this minor revision and then merge.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message