quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #73: Move hash join's probe and build node ...
Date Tue, 02 Aug 2016 00:39:42 GMT
Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/73#discussion_r73078148
  
    --- Diff: query_optimizer/physical/HashJoin.hpp ---
    @@ -172,18 +192,21 @@ class HashJoin : public BinaryJoin {
           const std::vector<expressions::AttributeReferencePtr> &right_join_attributes,
           const expressions::PredicatePtr &residual_predicate,
           const std::vector<expressions::NamedExpressionPtr> &project_expressions,
    -      const JoinType join_type)
    +      const JoinType join_type,
    +      const std::size_t estimated_right_cardinality)
           : BinaryJoin(left, right, project_expressions),
             left_join_attributes_(left_join_attributes),
             right_join_attributes_(right_join_attributes),
             residual_predicate_(residual_predicate),
    -        join_type_(join_type) {
    +        join_type_(join_type),
    +        estimated_right_cardinality_(estimated_right_cardinality) {
       }
     
       std::vector<expressions::AttributeReferencePtr> left_join_attributes_;
       std::vector<expressions::AttributeReferencePtr> right_join_attributes_;
       expressions::PredicatePtr residual_predicate_;
       JoinType join_type_;
    +  std::size_t estimated_right_cardinality_;
    --- End diff --
    
    It might not be good to couple the cardinality information here. We can still use `CostModel`
to estimate a physical plan's cardinality whenever needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message