Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: shixuan-fan <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-58-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-58-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Content-Type: text/plain
Message-Id: <20160719151144.64795E03A6@git1-us-west.apache.org>
Date: Tue, 19 Jul 2016 15:11:44 +0000 (UTC)
archived-at: Tue, 19 Jul 2016 15:11:49 -0000

Github user shixuan-fan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71358472
  
    --- Diff: relational_operators/WindowAggregationOperator.cpp ---
    @@ -67,6 +73,11 @@ serialization::WorkOrder* WindowAggregationOperator::createWorkOrderProto() {
       proto->set_query_id(query_id_);
       proto->SetExtension(serialization::WindowAggregationWorkOrder::window_aggr_state_index,
                           window_aggregation_state_index_);
    +
    +  std::vector<block_id> relation_blocks = input_relation_.getBlocksSnapshot();
    --- End diff --
    
    Good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---