Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-58-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-58-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Content-Type: text/plain
Message-Id: <20160718212717.80B88DFAF5@git1-us-west.apache.org>
Date: Mon, 18 Jul 2016 21:27:17 +0000 (UTC)
archived-at: Mon, 18 Jul 2016 21:27:23 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71233338
  
    --- Diff: query_optimizer/resolver/Resolver.cpp ---
    @@ -2656,11 +2666,12 @@ E::ScalarPtr Resolver::resolveFunctionCall(
       }
     
       // Make sure a naked COUNT() with no arguments wasn't specified.
    -  if ((aggregate->getAggregationID() == AggregationID::kCount)
    -      && (resolved_arguments.empty())
    -      && (!count_star)) {
    -    THROW_SQL_ERROR_AT(&parse_function_call)
    -        << "COUNT aggregate requires an argument (either scalar or star (*))";
    +  if ((aggregate != nullptr && aggregate->getAggregationID() == AggregationID::kCount)
    --- End diff --
    
    Code style for the bool expressions:
    
    https://google.github.io/styleguide/cppguide.html#Boolean_Expressions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---