quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #69: Process InitRebuildResponse message.
Date Thu, 28 Jul 2016 21:24:10 GMT
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/69
  
    Hi @zuyu 
    
    Couple of comments: 
    
    1. I am not sure if I agree with the way in which inheritance is being applied here. The
behavior of the base class should not be altered based on what the derived class is. 
    2. Let's not use confusing terminologies. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message