quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #69: Process InitRebuildResponse message.
Date Thu, 28 Jul 2016 21:08:30 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/69#discussion_r72703223
  
    --- Diff: query_execution/QueryManagerDistributed.cpp ---
    @@ -119,6 +119,27 @@ bool QueryManagerDistributed::fetchNormalWorkOrders(const dag_node_index
index)
       return generated_new_workorder_protos;
     }
     
    +void QueryManagerDistributed::processInitiateRebuildResponseMessage(const dag_node_index
op_index,
    +                                                                    const std::size_t
num_rebuild_work_orders) {
    +  // TODO(zuyu): Multiple workers support.
    +  query_exec_state_->setRebuildStatus(op_index, num_rebuild_work_orders, true);
    +
    +  if (num_rebuild_work_orders != 0u) {
    +    // Wait for the rebuild work orders to finish.
    +    return;
    +  }
    +
    +  markOperatorFinished(op_index);
    --- End diff --
    
    If we reach here, that means the operator did not issue any rebuild work orders, right?
Adding that as an explanation should be helpful. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message