quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #69: Process InitRebuildResponse message.
Date Thu, 28 Jul 2016 21:04:13 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/69#discussion_r72702522
  
    --- Diff: query_execution/PolicyEnforcerBase.hpp ---
    @@ -179,6 +180,18 @@ class PolicyEnforcerBase {
        **/
       virtual bool admitQuery(QueryHandle *query_handle) = 0;
     
    +#ifdef QUICKSTEP_DISTRIBUTED
    --- End diff --
    
    Same comment as in PolicyEnforcerBase.cpp. Why are we using this macro in the base class?
The base class can define virtual functions, as we wish. The single node derived implementation
can be a no-op or through an error if the function concerns only with the distributed implementation.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message