quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #64: Introduced Shiftboss for the distribut...
Date Wed, 27 Jul 2016 18:42:43 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    --- Diff: query_execution/QueryExecutionTypedefs.hpp ---
    @@ -73,9 +73,17 @@ enum QueryExecutionMessageType : message_type_id {
       kPoisonMessage,  // From the main thread to Foreman and Workers.
    +  kShiftbossRegistrationMessage,  // From Shiftboss to Foreman.
    +  kShiftbossRegistrationResponseMessage,  // From Foreman to Shiftboss.
    +  kQueryInitiateMessage,  // From Foreman to Shiftboss.
    +  kQueryInitiateResponseMessage,  // From Shiftboss to Foreman.
       kInitiateRebuildMessage,  // From Foreman to Shiftboss.
       kInitiateRebuildResponseMessage,  // From Shiftboss to Foreman.
    +  kQueryResultRelationMessage,  // From Foreman to Shiftboss.
    +  kQueryResultRelationResponseMessage,  // From Shiftboss to Foreman.
    --- End diff --
    There are two kinds of message patterns: X to Shiftboss and Shiftboss to X. I can see
that ShiftBoss constructor has appropriate type of registration related code. To appropriately
register X with the bus, have you already written the code or you plan to address it in the
next PR?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message