quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #64: Introduced Shiftboss for the distribut...
Date Mon, 25 Jul 2016 18:31:11 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/64#discussion_r72118495
  
    --- Diff: query_execution/Shiftboss.hpp ---
    @@ -0,0 +1,238 @@
    +/**
    + *   Licensed under the Apache License, Version 2.0 (the "License");
    + *   you may not use this file except in compliance with the License.
    + *   You may obtain a copy of the License at
    + *
    + *       http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing, software
    + *   distributed under the License is distributed on an "AS IS" BASIS,
    + *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *   See the License for the specific language governing permissions and
    + *   limitations under the License.
    + **/
    +
    +#ifndef QUICKSTEP_QUERY_EXECUTION_SHIFTBOSS_HPP_
    +#define QUICKSTEP_QUERY_EXECUTION_SHIFTBOSS_HPP_
    +
    +#include <cstddef>
    +#include <memory>
    +
    +#include "catalog/CatalogDatabaseCache.hpp"
    +#include "catalog/CatalogTypedefs.hpp"
    +#include "query_execution/QueryContext.hpp"
    +#include "query_execution/QueryExecutionTypedefs.hpp"
    +#include "query_execution/WorkerDirectory.hpp"
    +#include "threading/Thread.hpp"
    +#include "utility/Macros.hpp"
    +
    +#include "glog/logging.h"
    +
    +#include "tmb/address.h"
    +#include "tmb/id_typedefs.h"
    +#include "tmb/message_bus.h"
    +
    +namespace quickstep {
    +
    +class StorageManager;
    +
    +namespace serialization {
    +class CatalogDatabase;
    +class QueryContext;
    +}  // namespace serialization
    +
    +/** \addtogroup QueryExecution
    + *  @{
    + */
    +
    +/**
    + * @brief The Shiftboss accepts workorder protos from shiftboss, and assigns
    + *        the workorders to workers.
    + **/
    +class Shiftboss : public Thread {
    + public:
    +  /**
    +   * @brief Constructor.
    +   *
    +   * @param bus A pointer to the TMB.
    +   * @param storage_manager The StorageManager to use.
    +   * @param workers A pointer to the WorkerDirectory.
    +   * @param cpu_id The ID of the CPU to which the Shiftboss thread can be pinned.
    +   *
    +   * @note If cpu_id is not specified, Shiftboss thread can be possibly moved
    +   *       around on different CPUs by the OS.
    +  **/
    +  Shiftboss(tmb::MessageBus *bus,
    +            StorageManager *storage_manager,
    +            WorkerDirectory *workers,
    +            const int cpu_id = -1)
    +      : bus_(DCHECK_NOTNULL(bus)),
    +        storage_manager_(DCHECK_NOTNULL(storage_manager)),
    +        workers_(DCHECK_NOTNULL(workers)),
    +        cpu_id_(cpu_id),
    +        shiftboss_client_id_(tmb::kClientIdNone),
    +        foreman_client_id_(tmb::kClientIdNone),
    +        max_msgs_per_worker_(1),
    +        start_worker_index_(0u) {
    +    // Check to have at least one Worker.
    +    DCHECK_GT(workers->getNumWorkers(), 0u);
    +
    +    shiftboss_client_id_ = bus_->Connect();
    +    LOG(INFO) << "Shiftboss TMB client ID: " << shiftboss_client_id_;
    +    DCHECK_NE(shiftboss_client_id_, tmb::kClientIdNone);
    +
    +    // Messages between Foreman and Shiftboss.
    +    bus_->RegisterClientAsSender(shiftboss_client_id_, kShiftbossRegistrationMessage);
    --- End diff --
    
    I am unable to follow this - shouldn't we require two different types of buses? One for
communication between foreman and shiftboss and another for communication between workers
and shiftboss? I see only one bus instance being used here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message