quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shixuan-fan <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Date Wed, 20 Jul 2016 18:40:32 GMT
Github user shixuan-fan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71582584
  
    --- Diff: query_optimizer/tests/execution_generator/Select.test ---
    @@ -953,19 +953,79 @@ WHERE double_col < 0
     ==
     
     # Window Aggregation Test.
    -# Currently this is not supported, an empty table will be returned.
    -SELECT avg(int_col) OVER w FROM test
    +SELECT char_col, long_col, avg(long_col) OVER w FROM test
     WINDOW w AS
    -(PARTITION BY char_col
    - ORDER BY long_col DESC NULLS LAST
    +(ORDER BY char_col DESC NULLS LAST
    --- End diff --
    
    @zuyu I found that the code logic here is a little bit wrong. For window w/ NULLs, the
NULL values should be ignored rather than directly mark the result NULL. Only when all the
values in the window are NULLs should the window aggregate result be marked NULL. 
    
    Will fix this in the next commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message