quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shixuan-fan <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Date Tue, 19 Jul 2016 15:24:56 GMT
Github user shixuan-fan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71361264
  
    --- Diff: storage/WindowAggregationOperationState.cpp ---
    @@ -126,8 +121,8 @@ WindowAggregationOperationState* WindowAggregationOperationState::ReconstructFro
       const std::int64_t num_preceding = proto.num_preceding();
       const std::int64_t num_following = proto.num_following();
     
    -  return new WindowAggregationOperationState(database.getRelationSchemaById(proto.relation_id()),
    -                                             aggregate_function,
    +  return new WindowAggregationOperationState(database.getRelationSchemaById(proto.input_relation_id()),
    +                                             window_aggregate_function,
    --- End diff --
    
    Sounds great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message