quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shixuan-fan <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Date Tue, 19 Jul 2016 14:34:51 GMT
Github user shixuan-fan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71350702
  
    --- Diff: expressions/window_aggregation/WindowAggregateFunctionCount.cpp ---
    @@ -0,0 +1,59 @@
    +/**
    + *   Licensed to the Apache Software Foundation (ASF) under one
    + *   or more contributor license agreements.  See the NOTICE file
    + *   distributed with this work for additional information
    + *   regarding copyright ownership.  The ASF licenses this file
    + *   to you under the Apache License, Version 2.0 (the
    + *   "License"); you may not use this file except in compliance
    + *   with the License.  You may obtain a copy of the License at
    + * 
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + *   Unless required by applicable law or agreed to in writing,
    + *   software distributed under the License is distributed on an
    + *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + *   KIND, either express or implied.  See the License for the
    + *   specific language governing permissions and limitations
    + *   under the License.
    + **/
    +
    +#include "expressions/window_aggregation/WindowAggregateFunctionCount.hpp"
    +
    +#include <vector>
    +
    +#include "expressions/window_aggregation/WindowAggregationHandle.hpp"
    +#include "types/Type.hpp"
    +#include "types/TypeFactory.hpp"
    +#include "types/TypeID.hpp"
    +
    +#include "glog/logging.h"
    +
    +namespace quickstep {
    +
    +bool WindowAggregateFunctionCount::canApplyToTypes(
    +    const std::vector<const Type*> &argument_types) const {
    +  // COUNT may be nullary (i.e. COUNT(*)) or unary.
    +  return argument_types.size() <= 1;
    +}
    +
    +const Type* WindowAggregateFunctionCount::resultTypeForArgumentTypes(
    +    const std::vector<const Type*> &argument_types) const {
    +  if (!canApplyToTypes(argument_types)) {
    +    return nullptr;
    +  }
    +
    +  return &TypeFactory::GetType(kLong);
    +}
    +
    +WindowAggregationHandle* WindowAggregateFunctionCount::createHandle(
    +    std::vector<const Type*> &&argument_types,
    --- End diff --
    
    You are right. A reference would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message