quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Date Mon, 18 Jul 2016 23:36:01 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71250408
  
    --- Diff: storage/WindowAggregationOperationState.proto ---
    @@ -19,15 +19,15 @@ syntax = "proto2";
     
     package quickstep.serialization;
     
    -import "expressions/aggregation/AggregateFunction.proto";
    +import "expressions/window_aggregation/WindowAggregateFunction.proto";
     import "expressions/Expressions.proto";
     
     message WindowAggregationOperationState {
    -  required int32 relation_id = 1;
    -  required AggregateFunction function = 2;
    -  repeated Scalar arguments = 3;
    -  repeated Scalar partition_by_attributes = 4;
    -  required bool is_row = 5;
    -  required int64 num_preceding = 6;  // -1 means UNBOUNDED PRECEDING.
    -  required int64 num_following = 7;  // -1 means UNBOUNDED FOLLOWING.
    +  required int32 input_relation_id = 1;
    +  required WindowAggregateFunction function = 3;
    --- End diff --
    
    Something wrong w/ the number assignments and below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message