quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #58: QUICKSTEP-20: Supported Window Aggrega...
Date Mon, 18 Jul 2016 21:27:17 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/58#discussion_r71233338
  
    --- Diff: query_optimizer/resolver/Resolver.cpp ---
    @@ -2656,11 +2666,12 @@ E::ScalarPtr Resolver::resolveFunctionCall(
       }
     
       // Make sure a naked COUNT() with no arguments wasn't specified.
    -  if ((aggregate->getAggregationID() == AggregationID::kCount)
    -      && (resolved_arguments.empty())
    -      && (!count_star)) {
    -    THROW_SQL_ERROR_AT(&parse_function_call)
    -        << "COUNT aggregate requires an argument (either scalar or star (*))";
    +  if ((aggregate != nullptr && aggregate->getAggregationID() == AggregationID::kCount)
    --- End diff --
    
    Code style for the bool expressions:
    
    https://google.github.io/styleguide/cppguide.html#Boolean_Expressions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message