quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #54: Introduced QueryManagerBase, and renam...
Date Tue, 12 Jul 2016 18:52:53 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/54#discussion_r70499338
  
    --- Diff: query_execution/QueryManagerBase.hpp ---
    @@ -255,69 +212,75 @@ class QueryManager {
        *         otherwise.
        **/
       inline bool checkOperatorExecutionOver(const dag_node_index index) const {
    -    if (checkRebuildRequired(index)) {
    -      return (checkNormalExecutionOver(index) && checkRebuildOver(index));
    -    } else {
    -      return checkNormalExecutionOver(index);
    -    }
    +    return this->checkNormalExecutionOver(index) &&
    +           (!checkRebuildRequired(index) || this->checkRebuildOver(index));
    --- End diff --
    
    I would argue that the original implementation is easier to read and debug. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message