quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From navsan <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #25: DO NOT MERGE: Move createNewBlock() out of th...
Date Sat, 09 Jul 2016 05:45:14 GMT
Github user navsan commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/25
  
    I made all the changes, per @zuyu's comments. But, in a strange turn of events, performance
actually worsened when I moved `createNewBlock()` out of the critical section. We didn't get
anywhere in investigating why that might be the case. I'm closing this PR for now and leaving
it to future work to reopen it, figure out what's going on, and then merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message