quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From navsan <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #43: Remove unused AlwaysCreateBlockInsertDestinat...
Date Sat, 09 Jul 2016 05:40:59 GMT
Github user navsan commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/43
  
    @hbdeshmukh We were wrong: `always_mark_full` is indeed being used [in the sort function](https://github.com/apache/incubator-quickstep/blob/master/storage/StorageBlock.cpp#L940).
I'm not sure why it's necessary there, but I'd rather not go change that now. I'm reverting
that commit and only submitting the removal of the AlwaysCreateBlockInsertDestination (first
commit).   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message