quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #52: Renamed Foreman related classes.
Date Fri, 08 Jul 2016 13:17:05 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/52#discussion_r70071564
  
    --- Diff: query_execution/CMakeLists.txt ---
    @@ -82,12 +86,8 @@ target_link_libraries(quickstep_queryexecution_Foreman
                           quickstep_threading_ThreadUtil
                           quickstep_utility_EqualsAnyConstant
                           quickstep_utility_Macros
    -                      tmb)
    -target_link_libraries(quickstep_queryexecution_ForemanLite
    -                      glog
    -                      quickstep_threading_Thread
    -                      quickstep_utility_Macros
    -                      tmb)
    +                      tmb
    +                      ${GFLAGS_LIB_NAME})
    --- End diff --
    
    No, it starts w/ `$`, so it should be in the last.
    
    See [here](https://github.com/apache/incubator-quickstep/blob/master/storage/CMakeLists.txt#L291)
for example regarding `${PROTOBUF_LIBRARY}`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message