quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #49: QUICKSTEP-20: Added ExecutionGenerator...
Date Thu, 07 Jul 2016 19:56:50 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/49#discussion_r69975485
  
    --- Diff: query_optimizer/cost_model/SimpleCostModel.hpp ---
    @@ -88,6 +89,10 @@ class SimpleCostModel : public CostModel {
       std::size_t estimateCardinalityForAggregate(
           const physical::AggregatePtr &physical_plan);
     
    +  // Return the estimated cardinality of the input plan
    --- End diff --
    
    Code style: Add the period `.` in the end.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message