Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: craig-chasseur <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
Message-ID: <git-pr-30-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #30: Fix conditional per-target flags for l...
Content-Type: text/plain
Date: Tue, 14 Jun 2016 07:55:03 +0000 (UTC)
archived-at: Tue, 14 Jun 2016 07:55:09 -0000

GitHub user craig-chasseur opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/30

    Fix conditional per-target flags for lexer

    set_target_properties() overwrites per-target COMPILE_FLAGS rather than replacing them. Also, compiler flags should be checked before enabling them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/craig-chasseur/incubator-quickstep lexer-flags-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 29768a7297746606089c6b2ebca1a9bf44180614
Author: Craig Chasseur <spoonboy42@gmail.com>
Date:   2016-06-14T07:51:52Z

    Fix conditional per-target flags for lexer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---