Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-35-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-35-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #35: QUICKSTEP-20: Added Parser support for...
Content-Type: text/plain
Message-Id: <20160617185035.809BCE049D@git1-us-west.apache.org>
Date: Fri, 17 Jun 2016 18:50:35 +0000 (UTC)
archived-at: Fri, 17 Jun 2016 18:50:42 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/35#discussion_r67558193
  
    --- Diff: parser/SqlParser.ypp ---
    @@ -1332,6 +1369,83 @@ opt_limit_clause:
         }
       }
     
    +opt_window_clause:
    +  {
    +    $$ = nullptr;
    +  }
    +  | window_declaration_list
    +
    +window_declaration_list:
    +  window_declaration {
    +    $$ = new quickstep::PtrList<quickstep::ParseWindow>();
    +    $$->push_back($1);
    +  }
    +  | window_declaration_list window_declaration {
    +    $$ = $1;
    +    $$->push_back($2);
    +  }
    +
    +window_declaration:
    --- End diff --
    
    First, we should sort them whenever possible.
    In addition, in thiw PR we should commit code sorted in alphabetic order.
    Finally, there are some committed but unsorted code, so we should fix in another separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---