Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: hbdeshmukh <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-14-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-14-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Content-Type: text/plain
Message-Id: <20160612000315.3FF6ADFE2E@git1-us-west.apache.org>
Date: Sun, 12 Jun 2016 00:03:15 +0000 (UTC)
archived-at: Sun, 12 Jun 2016 00:03:20 -0000

Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713594
  
    --- Diff: query_execution/PolicyEnforcer.hpp ---
    @@ -0,0 +1,168 @@
    +/**
    + *   Copyright 2016, Quickstep Research Group, Computer Sciences Department,
    + *     University of Wisconsin—Madison.
    + *
    + *   Licensed under the Apache License, Version 2.0 (the "License");
    + *   you may not use this file except in compliance with the License.
    + *   You may obtain a copy of the License at
    + *
    + *       http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing, software
    + *   distributed under the License is distributed on an "AS IS" BASIS,
    + *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *   See the License for the specific language governing permissions and
    + *   limitations under the License.
    + **/
    +
    +#ifndef QUICKSTEP_QUERY_EXECUTION_POLICY_ENFORCER_HPP_
    +#define QUICKSTEP_QUERY_EXECUTION_POLICY_ENFORCER_HPP_
    +
    +#include <cstddef>
    +#include <memory>
    +#include <queue>
    +#include <unordered_map>
    +#include <vector>
    +
    +#include "query_execution/QueryExecutionTypedefs.hpp"
    +#include "query_execution/QueryManager.hpp"
    +#include "query_execution/WorkerMessage.hpp"
    +#include "utility/Macros.hpp"
    +
    +#include "glog/logging.h"
    +
    +#include "tmb/id_typedefs.h"
    +#include "tmb/message_bus.h"
    +#include "tmb/tagged_message.h"
    +
    +namespace quickstep {
    +
    +class CatalogDatabaseLite;
    +class QueryHandle;
    +class StorageManager;
    +
    +/**
    + * @brief A class that ensures that a high level policy is maintained
    + *        in sharing resources among concurrent queries.
    + **/
    +class PolicyEnforcer {
    + public:
    +  /**
    +   * @brief Constructor.
    +   *
    +   * @param foreman_client_id The TMB client ID of the Foreman.
    +   * @param num_numa_nodes Number of NUMA nodes used by the system.
    +   * @param catalog_database The CatalogDatabase used.
    +   * @param storage_manager The StorageManager used.
    +   * @param bus The TMB.
    +   **/
    +  PolicyEnforcer(const tmb::client_id foreman_client_id,
    +                 const std::size_t num_numa_nodes,
    --- End diff --
    
    Is there a reason why we should make it optional? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---